Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to choose refquota zfs field to apply quotas #423

Open
tahajahangir opened this issue Aug 17, 2022 · 4 comments
Open

Option to choose refquota zfs field to apply quotas #423

tahajahangir opened this issue Aug 17, 2022 · 4 comments
Assignees
Labels
backlog Will be picked up as a roadmap item. enhancement Add new functionality to existing feature
Milestone

Comments

@tahajahangir
Copy link

Describe the problem/challenge you have
Currently, PVC sizes are applied using zfs quota field. This way, taking snapshot of a volume, decreases the available space of the PVC. I think this is not the desired behavior for many users.

Describe the solution you'd like
A simple solution is using refquota instead of quota.
A better solution is adding an option (operator-wide, per StorageClass or per PVC) to apply limits with refquota.
Another solution is provide a way (e.g. with annotations) to apply quota and refquota limits independently. For example, we can use the capacity property of PVC for refquota, and provide an annotation for limiting the zfs quota.

Environment:*

  • Not important
@rdegez
Copy link

rdegez commented Sep 15, 2022

We have the exact same issue and I wonder how many people are actualy using snapshots in production without this!

@Abhinandan-Purkait Abhinandan-Purkait added backlog Will be picked up as a roadmap item. enhancement Add new functionality to existing feature labels Jun 6, 2024
@Abhinandan-Purkait
Copy link
Member

@sabzsystem I see a PR was raised to address this? Why was this closed?

We can take this up as a roadmap item. Thanks

@niladrih
Copy link
Member

Continuing the discussion here @cinapm.

I have one issue with #542: I think the CSI driver shouldn't be pinned to the quota/refquota choice it made at deploy time. It should be configurable via a storageClass parameter. Admins could choose if the provisioner uses quota/refquota at provision based on the StorageClass configuration.

I'm not a ZFS pro, but does the quota affect volume expansion?

@tiagolobocastro @avishnu @dsavitskiy you thoughts?

@Abhinandan-Purkait Abhinandan-Purkait added this to the v4.2 milestone Sep 26, 2024
@Abhinandan-Purkait Abhinandan-Purkait self-assigned this Sep 26, 2024
@Abhinandan-Purkait
Copy link
Member

The functionality has been added as part of PR #542 . Will try to add a test for the change before we close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Will be picked up as a roadmap item. enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants