Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop ini syntax to couple multiple instances from same model (framework) #82

Open
DirkEilander opened this issue Oct 2, 2018 · 3 comments

Comments

@DirkEilander
Copy link
Collaborator

Right now we can only use the abbreviations of the implemented models (PCR, DFM etc) in the ini-file syntax under the [models] and [exchanges] sections. As wflow is a framework with several models rather than one model there are usecases where we want to couple a wflow hydrological model with the wflow kin wave routing or reservoir models. For these usecases we need to be able to have multiple instances of the same model. A possible solution would be to make it possible (optional) to use the following syntax (or similar) to reference

[models]
W3RA=WFL/W3RA/wflow_W3RA.ini@WFL
routing=WFL/W3RA/wflow_routing.ini@WFL
DFM=DFM/dfm_settings.nam@DFM

[exchanges]
# runoff directly from W3RA Sr0 variable
W3RA.Sr0*cellArea=DFM.rain*ba*1000@1d
# upstream routed discharge from wflow routing module
routing.Qtot*86400@grid_us=DFM.rain*ba*1000@1d_us
@DirkEilander DirkEilander changed the title develop ini syntax to couple multiple instances from same model (framework) feature request: develop ini syntax to couple multiple instances from same model (framework) Oct 2, 2018
@JannisHoch
Copy link
Contributor

Hi @DirkEilander
good point.
I am not an expert in using wflow, but can you not also specify the hydrologic model to routing module coupling in the wflow ini-file?
This would make the GLOFRIM ini-file bit leaner.
Or would it then not possible to get runoff and routed discharge from one and the same BMI isntance but we have to address hydrologic model and routing module independently?

@DirkEilander
Copy link
Collaborator Author

@ChippChapp The coupling between the wflow hydrology and routing is now also done via BMI. By making the naming flexible we can also combine different wflow modules in GLOFRIM

@JannisHoch
Copy link
Contributor

JannisHoch commented Oct 18, 2018

@DirkEilander
alrigtht, great work then!
Think we should update the documentation then accordingly as well as update the template GLOFRIM ini-file.
Happy to do the former if you do the latter ;)

  • Update template GLOFRIM ini-file

  • Update readthedocs

@DirkEilander DirkEilander changed the title feature request: develop ini syntax to couple multiple instances from same model (framework) develop ini syntax to couple multiple instances from same model (framework) Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants