Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: support pull-down list in DSP input parameter entry #1759

Open
yuanchi2807 opened this issue Sep 6, 2023 · 5 comments
Open
Labels
community feature/ds-pipelines Data Science Pipelines feature (aka DSP) kind/enhancement New functionality request (existing augments or new additions) needs-info Further information is requested from the reporter or from another source priority/normal An issue with the product; fix when possible

Comments

@yuanchi2807
Copy link

Feature description

The current UI supports pipeline input parameter entries as text boxes only.
For boolean or list entries, end users suggested a pull down menu of allowed values, such as True/False, improves user experience significantly.

Describe alternatives you've considered

No response

Anything else?

No response

@yuanchi2807 yuanchi2807 added kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible untriaged Indicates the newly create issue has not been triaged yet labels Sep 6, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Sep 6, 2023
@andrewballantyne
Copy link
Member

@yuanchi2807 As far as I can tell, there is no such thing as "boolean" in the Tekton infra. How do you propose we support knowing this field is "boolean"? cc @yannnz

Each declared parameter has a type field, which can be set to either array or string. array is useful in cases where the number of compilation flags being supplied to the Pipeline varies throughout its execution. If no value is specified, the type field defaults to string. When the actual parameter value is supplied, its parsed type is validated against the type field. The description and default fields for a Parameter are optional.

-Source

@andrewballantyne andrewballantyne added the needs-info Further information is requested from the reporter or from another source label Sep 6, 2023
@yuanchi2807
Copy link
Author

yuanchi2807 commented Sep 6, 2023

@andrewballantyne Not sure either. Relaying end user comments after we asked them to configure a pipeline that included True/False toggle. We asked them to literally type in True or False.
Could v2 be relevant here?
https://www.kubeflow.org/docs/components/pipelines/v2/data-types/parameters/

@andrewballantyne
Copy link
Member

Oh interesting -- there may be metadata on the type like Elyra's task naming isn't with the Tekton PipelineRun spec 🤔

@HumairAK can you help investigate if that's the case. If there is metadata, we can definitely react on that.

@roytman
Copy link

roytman commented Sep 8, 2023

PipelineParams have an optional field - pattern, can it be used to provide some hints to the UI. e.g. pattern = "True|False" or pattern = "split_sentence | language_identification" (if the pattern is not empty, it can be shown by the UI and the user input will be validated)

@andrewballantyne
Copy link
Member

Most interesting of an idea... we could definitely look into this. @yannnz for the UX.

Assuming it properly reflects in the run and can be used effectively from the source of Elyra or the SDK (cc @harshad16 @HumairAK), the implementation shouldn't be too complex.

Would we look for just supporting the following types?

  • unbounded strings (what we do today)
  • arrays (maybe some +/- interface)
  • booleans (maybe a checkbox or toggle?)
  • an enum/dictionary (a dropdown list of items -- can only pick from one)

We'll have to support the pattern as needed. However, I think everything is strings or array of strings in the end. So we are still somewhat limited (maybe Booleans are just Dictionary/enums?).

@DaoDaoNoCode DaoDaoNoCode added feature/ds-pipelines Data Science Pipelines feature (aka DSP) and removed untriaged Indicates the newly create issue has not been triaged yet labels Sep 11, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from Needs prioritization to To do in ODH Dashboard Planning Sep 11, 2023
@andrewballantyne andrewballantyne moved this from Dev To do to UX Backlog in ODH Dashboard Planning Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feature/ds-pipelines Data Science Pipelines feature (aka DSP) kind/enhancement New functionality request (existing augments or new additions) needs-info Further information is requested from the reporter or from another source priority/normal An issue with the product; fix when possible
Projects
Status: No status
Status: No status
Status: UX Backlog
Development

No branches or pull requests

5 participants