-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vote: Archive the artifacts repo #126
Comments
@opencontainers/tob PTAL |
LGTM with the assumption that we update the readme with a pointer to the image-spec guidance. |
Can we update the readme first? It'd be nice for the vote here to cover one action (archival), not multiple (archival + not-fully-specified readme updates). |
Just opened opencontainers/artifacts#67 to address the README |
I'm supportive of unifying the content across the specs, as this was the goal of image-spec/pull #770: Artifact spec additions and distribution-spec/pull #65, starting way back in March of 2019. As a result, there was an OCI TOB Vote to create the artifacts repo, which included:
With broad adoption of OCI Artifacts and the evolution of artifacts/pull: OCI artifact manifest, Phase 1-Reference Types #29, we are getting closer to achieving the goal for leveraging the investments users, cloud providers and ISVs have in their registries. Enabling artifact authors to distribute new types, without having to create yet more package managers helps the community quickly innovate new ideas. To complete the effort, and archive the artifact repo, the TOB may want to consider addressing the charter of OCI Artifacts:
The "clearing house for well-known types" evolved to Registering Unique Types with IANA, which alleviated OCI artifact maintainers from becoming the bottleneck. The main value for OCI Artifacts became: Artifact Authors Guidance which helps authors and registry operators understand how to implement and support new artifact types. With the addition of the Regarding the The guidance in OCI Artifacts is still accurate, as the guidance is both backwards and forward compatible. What's being added is formalization of the As incremental steps, before archiving the artifacts repo, I'd suggest:
|
@SteveLasker This sounds mainly good:
Can we put together PRs to add an OCI Artifacts (archived)This repo has been archived since July 2023. The creation of this repository and subsequent efforts within OCI (i.e. Working Group: Reference Types (archived)) have resulted in the following pages which provide guidance for OCI Artifact Authors relating to implementing a single OCI specification:
?? |
Once the 1.1 spec is released, there’s lots of good conversations. |
there's a good conversation right in front of you! |
Yup, and I'm looking forward to this making its completion. However, the churn that’s happened along the way has caused confusion, frustration, and randomization across cloud providers and implementers. |
I'd also suggest the emojis don't exactly build trust around inclusive, positive collaboration. |
This is basically the exact opposite of my interpretation of how the last few years have gone in the OCI. Based on past experiences discussing things with you, I don't think we're going to have a productive discussion so I'm not going to continue but I felt it worthwhile to at least provide a counter interpretation on the history of OCI artifacts for future readers. |
My concerns with the artifact repo are that it is out-of-date, which result in it not being forward compatible (tooling written to that repo's guidance will incorrectly process artifacts made according to the current image-spec guidance), and in at least one place I believe the advice conflicts with descriptor requirement in the 1.0 image-spec. The "out of date" comes from the advice to use the There is then a suggestion that a null config reference can be used, which I'm not entirely sure what that means. The config descriptor is required in the spec. And the config blob content must match the config descriptor media type. We have also found that some registries refuse a blob of 0 length.
I believe the specs themselves now includes guidance for authors and registry operators. Updating the charter for these specs can be brought up as a separate issue/PR to the TOB. I don't believe we need to wait for that change before deciding on this issue, since it is recommending we do something which we are already doing.
Given that the artifacts repo conflicts with guidance in the image-spec, and the guidance in image-spec can be followed with existing 1.0 conformant registries, I feel the lesser of the bad options is to archive the artifact repo now rather than leaving up the conflicting guidance. In the scenarios where a dedicated config blob can be used, the guidance in the image-spec RC aligns with the artifact repo. And in the scenario where there is no config blob content, the image-spec RC advice conforms to the descriptor spec requirements where the artifact repo guidance does not. |
+1, hence this vote |
See proposed archive readme on the main branch ... https://github.com/opencontainers/artifacts/tree/main |
LGTM, thanks @mikebrow! |
As noted above, we're looking forward to Image and Distribution specs releasing, and adding content for Artifacts Authors and registry operators. We've even queued up content from the Artifacts repo to redirect folks. Although the link is fairly empty in comparison to the: Artifact Authors Guidance
I'm 100% behind the Are we really suggesting all the artifacts deployed today would break if they set the Which leaves the question, why is the TOB seemingly rushing to archive a repo that got the community where it is today? Seems we could focus on completing the docs and releasing the specs, so there's a natural and obvious transition point. |
Support for artifacts via From distribution-spec:
From image-spec
Why exactly does it matter what got the community where it is today? These are important, widely-used specifications. The emphasis should be placed on functionality and clarity vs. the history and persons involved. Compare this repo to the wg-reference-types repo which was created on Dec 15, 2021 and archived less than one year later on Sep 23, 2022. Nobody objected to archiving that when the time came... why should this repo be treated any different? |
LGTM |
LGTM, thanks |
@jdolitsky yes, the As for treating working groups and projects differently, they are, as defined by the TOB working groups, I'm really not understanding why there's such a rush to archive a stable project, while image and distribution complete their process, letting the natural flow occur. |
There is no rush. We have been discussing it for a year. |
Who's "we". When this TOB vote was initiated, in what I assume was a TOB meeting, there was no invite to the artifact maintainers to have said discussion. |
It's not, though. Its existence is misleading and harmful to the broader ecosystem.
I am having a really hard time parsing this. Do you mean that we should wait to archive the artifacts repo until after the releases? |
LGTM (and if I'm counting correctly, that means this motion passes). FWIW, I'm not sure whether the precise discussion on whether we want to completely delete the text of the repo or just add a header pointing to the new guidance is necessarily a TOB issue -- but a motion to archive it presumably means whatever statement is put into the artefacts README needs to unreservedly state the archived status of the project (as is the case with the wg-reference-types repo, for instance). |
LGTM |
@cyphar @jonjohnsonjr @jdolitsky While not specifically mentioning you, wanted to share some insights/thoughts from someone who is semi new into the OCI space (compared to the TOB). The artifacts repo and the WG blazed the trail for OCI artifacts and their incorporation into the image and distribution specs that are associated with the 1.1 release. It would be good to see this repository stand for historical purposes in an archived state, but making it explicitly clear the current state of the repository and providing references to the official documentation, guidance and status of Artifacts in OCI. Given that the release of 1.1 is when the changes of Artifacts becomes official, the archival of the repository should occur immediately following the release. Associated documentation on the current and future direction has already started to be incorporated into #70. |
The vote has passed 7/9. Thanks everyone. |
The upcoming spec changes address the question of artifacts. The following repo served us well at the time, but now can only cause confusion for people new to OCI: https://github.com/opencontainers/artifacts
for more info see opencontainers/artifacts#63
I'll call the vote for @opencontainers/tob. Please approve, request changes, reply with LGTM, or not (and hopefully say why!).
A 2/3 approval is required here, so 6/9 of the TOB members must approve.
The text was updated successfully, but these errors were encountered: