Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log messages don't have a level set #569

Open
nlgotz opened this issue Dec 20, 2024 · 1 comment
Open

Log messages don't have a level set #569

nlgotz opened this issue Dec 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nlgotz
Copy link
Contributor

nlgotz commented Dec 20, 2024

When managing logs of gnmic containers, there's no log levels, which makes it really difficult to parse and determine if the log messages are "good" info type logs or "warn"/"error"/"critical" errors.

It would be nice to have logs that can have a level attached to them to make it easy to alert on an increase of critical logs or something similar.

@karimra
Copy link
Collaborator

karimra commented Dec 30, 2024

That's because gNMIc uses golang's default logger which didn't support structured logging until go1.21. There is a bit of work needed to switch to slog

@karimra karimra added the enhancement New feature or request label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants