Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigs_cis: input checking #428

Open
gfudenberg opened this issue Mar 30, 2023 · 2 comments
Open

eigs_cis: input checking #428

gfudenberg opened this issue Mar 30, 2023 · 2 comments

Comments

@gfudenberg
Copy link
Member

currently the user can pass a phasing_track with any number of columns, but the 4th column is used for phasing. With the default output of bioframe.frac_gc for a cooler bintable, desired GC content would be the 5th column rather than the 4th.

potential solution:

  • require that phasing_track has 4 and only 4 columns
@sergpolly
Copy link
Member

so i think this is related to #333 - a bit - in CLI this could be addressed by using fname::value_column_name syntax

but ... i guess this isn't about cli ... - maybe we could provide a value column name as a parameter ?
and also regarding frac_gc - isn't the desired value in the 5th column just because typically one gives a bintable to it as an input - i.e. bintabel with the "weight" column ?

@gfudenberg
Copy link
Member Author

I think an idea we discussed was that having a "track format" would simplify API a bit, as users wouldn't need this extra "value_col=track_value_col" argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants