Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mypy with pyright #4404

Open
emdneto opened this issue Jan 31, 2025 · 1 comment
Open

Replace mypy with pyright #4404

emdneto opened this issue Jan 31, 2025 · 1 comment
Labels
build & infra Issues related to build & infrastructure.

Comments

@emdneto
Copy link
Member

emdneto commented Jan 31, 2025

We currently use Pyright in the contrib repository. However, in the core repository, Pyright is configured with typeCheckingMode = "off". During the SIG meeting on 01/09/2025, we discussed and agreed to replace mypy with Pyright in the core repository as well. This change will ensure both repositories use the same type checker, improving consistency across the codebase.

@emdneto emdneto added the build & infra Issues related to build & infrastructure. label Jan 31, 2025
@pierceroberts
Copy link

Hello @emdneto !
I am looking to contribute to the project if I can and this seemed doable!
I looked into this a bit and would like you the mypy.ini, mypy-requirements.txt, and mypy-relaxed.ini deleted in addition to the lines in toml referring to mypy?

In addition I noticed this pyright isn't set up in the pre-commit yaml in either repos you mentioned above. Do you want the pre-commit hooks updated too?
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Issues related to build & infrastructure.
Projects
None yet
Development

No branches or pull requests

2 participants