Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

FSRS does not respect “Reset” entries in the card metadata #19

Open
sobjornstad opened this issue May 25, 2023 · 7 comments
Open

FSRS does not respect “Reset” entries in the card metadata #19

sobjornstad opened this issue May 25, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@sobjornstad
Copy link

After using “Reset Flashcards for Rem”, an entry is placed in the card's history, but FSRS seems to ignore this entry; the card's interval is not actually reset at next review.

image

image

@L-M-Sherlock
Copy link
Member

L-M-Sherlock commented May 26, 2023

I need help. I don't know what should the plugin response to this action. Is it an input of getNextSpacingDate?
@bjsi, if you are available, I hope you could help me here.

@L-M-Sherlock L-M-Sherlock added the bug Something isn't working label May 26, 2023
@sobjornstad
Copy link
Author

sobjornstad commented May 26, 2023

The card should completely ignore all previous repetition history and behave as if it is a new card.

@bjsi
Copy link
Contributor

bjsi commented May 26, 2023

Hmm I thought we were automatically filtering repetition history data before sending to plugin schedulers. I will check and confirm
EDIT: Seems like we are doing the filtering correctly.

@bjsi
Copy link
Contributor

bjsi commented May 26, 2023

@sobjornstad would you mind exporting the flashcard in your example?

@sobjornstad
Copy link
Author

@bjsi
Copy link
Contributor

bjsi commented May 30, 2023

Thanks, I think I understand what is going on.

@bjsi
Copy link
Contributor

bjsi commented May 30, 2023

I made a change in the RemNote codebase which will hopefully fix this issue :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants