replicalimits unit tests do not include checks for Scale resources #419
Labels
Comments
skaven81
added a commit
to skaven81/gatekeeper-library
that referenced
this issue
Oct 27, 2023
…ly. Fixes open-policy-agent#419 Signed-off-by: Paul Krizak <[email protected]>
|
This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
|
poke the bot |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
general/replicalimitsConstraintTemplate in the library only has unit tests that validate updates to a Deployment resource. It does not check for Scale resources, which get generated when runningkubectl scalecommands.There is also a bug in the Rego because in the event of
kubectl scale deploy <name> --replicas=0, the Scale resource has an empty spec (soinput.review.object.specis empty) and a violation is generated, even if a range allows zero as a valid value.The text was updated successfully, but these errors were encountered: