Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[authentication-keycloak] Support configuration of logoutOptions #78

Open
3 tasks done
ChristophMaskos opened this issue Dec 5, 2024 · 1 comment
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@ChristophMaskos
Copy link
Contributor

Issue description

Please extend the package so that the Logout method can optionally be passed a parameter "redirectUri".

logout(options?: { redirectUri: string }) {
   const logoutOptions = options || this.#logoutOptions
   this.#keycloak.logout(logoutOptions );
}

See Keycloak-API

Validations

@ChristophMaskos ChristophMaskos added the enhancement New feature or request label Dec 6, 2024
@mbeckem
Copy link
Contributor

mbeckem commented Dec 10, 2024

This is a good suggestion. We currently already have this.#logoutOptions, but they cannot be configured. We probably left that out of the initial version.

It would probably be a good idea to support both: package level configuration for logoutOptions (for simple use cases) and an optional parameter like in your example (for advanced / dynamic redirections).

We might get to this requirement during maintenance, but we're currently focusing on technical issues like the chakra v3 update. However, pull requests are always welcome.

@mbeckem mbeckem changed the title Enhancement of the authentication-keycloak package. [authentication-keycloak] Support configuration of logoutOptions Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants