Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using vite-plugin-pioneer requires pnpm's shamefully-hoist option #61

Open
mbeckem opened this issue Jun 9, 2023 · 2 comments
Open

Using vite-plugin-pioneer requires pnpm's shamefully-hoist option #61

mbeckem opened this issue Jun 9, 2023 · 2 comments

Comments

@mbeckem
Copy link
Collaborator

mbeckem commented Jun 9, 2023

This should be resolved in the near future.

See https://github.com/open-pioneer/build-tools/releases/tag/%40open-pioneer%2Fvite-plugin-pioneer%400.8.6
@mbeckem mbeckem added the bug Something isn't working label Jun 9, 2023
@mbeckem mbeckem mentioned this issue Jun 12, 2023
Closed
22 tasks
@mbeckem mbeckem removed the bug Something isn't working label Jun 16, 2023
@mbeckem
Copy link
Collaborator Author

mbeckem commented Jun 16, 2023

See also vitejs/vite#13538

@mbeckem
Copy link
Collaborator Author

mbeckem commented Jun 16, 2023 •
edited
Loading

Note: shamefully-hoist works around this problem in two ways:

  • The plugin uses bare imports instead of fully resolved locations. This requires that all packages used anywhere are importable from the virtual module.
  • Shamefully-hoist is a pnpm option that does that automatically (i.e. all dependencies available via node_modules/*), which is really bad for dependency hygiene and should thus be resolved in the future.

@mbeckem mbeckem transferred this issue from open-pioneer/trails-starter Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbeckem