Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.swift issue with new released flatbuffers version #164

Closed
christianovo opened this issue Jan 8, 2025 · 1 comment · Fixed by #165
Closed

Package.swift issue with new released flatbuffers version #164

christianovo opened this issue Jan 8, 2025 · 1 comment · Fixed by #165

Comments

@christianovo
Copy link

Hi all,

the Package.swift dependency to flatbuffers needs to be fixed because right now the SDK points to a specified version using "from" parameter:

.package(url: "https://github.com/google/flatbuffers.git", from: "24.3.25")

but this needs to be changed to:

.package(url: "https://github.com/google/flatbuffers.git", exact: "24.3.25")

because now flatbuffers have a new version, and if we try to update all the packages from our project, also flatbuffers is updated and this cause a compile issue because OpenMeteo validate the version using:

public static void ValidateVersion() { FlatBufferConstants.FLATBUFFERS_24_3_25(); }

@patrick-zippenfenig
Copy link
Member

I pinned the version and then spend almost 3 hours to fix various release build issues in python and typescript packages again....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants