From 72def3b4b37decc3dd17e102b1f0a04c8320b795 Mon Sep 17 00:00:00 2001 From: jelgerjansen Date: Thu, 7 Nov 2024 20:24:55 +0100 Subject: [PATCH 1/2] Use Modelica.Units.SI.TemperatureDifference for dT_nominal --- .../Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo b/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo index 05e908172..8a3182d39 100644 --- a/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo +++ b/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo @@ -12,7 +12,7 @@ model Thermostatic3WayValve "Thermostatic 3-way valve with hot and cold side" annotation(Dialog(tab="Advanced")); parameter Real y_start(min=0, max=1) = 0 "Initial valve opening" annotation(Dialog(enable=dynamicValve,tab="Dynamics", group="Filter")); - parameter Modelica.Units.SI.Temperature dT_nominal=50 + parameter Modelica.Units.SI.TemperatureDifference dT_nominal=50 "Nominal/maximum temperature difference between inlet ports, used for regularization"; Modelica.Blocks.Interfaces.RealInput TMixedSet From e8d8ceffd3a91dc645ca6eefeb53902ff501663d Mon Sep 17 00:00:00 2001 From: jelgerjansen Date: Tue, 12 Nov 2024 17:52:16 +0100 Subject: [PATCH 2/2] Add revision note and fix format of other revision notes. --- .../Simplified/Thermostatic3WayValve.mo | 39 +++++++++++++++---- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo b/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo index 8a3182d39..3060905d9 100644 --- a/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo +++ b/IDEAS/Fluid/Actuators/Valves/Simplified/Thermostatic3WayValve.mo @@ -137,16 +137,41 @@ equation ", revisions=" ")); end Thermostatic3WayValve;