Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand to expect keywords from the IVOA Spectrum data model? #9

Open
kelle opened this issue Mar 31, 2023 · 2 comments
Open

Expand to expect keywords from the IVOA Spectrum data model? #9

kelle opened this issue Mar 31, 2023 · 2 comments

Comments

@kelle
Copy link

kelle commented Mar 31, 2023

Are you interested in pull requests which expand the scope and generality of this package? In particular, we would add some expected header keywords to the HeaderSchema class from the IVOA Spectrum Data Model such as RA, Dec, Aperture, Specband, Spec_val, Spec_BW, TDMIN1, TDMAX1. Would you want to see these additions in a pull request or would you prefer we make our own custom HeaderSchema class for spectra?

@kelle kelle changed the title Expand to Spectrum1D datamodel? Expand to expect keywords from the IVOA Spectrum data model? Mar 31, 2023
@maxnoe
Copy link
Member

maxnoe commented Mar 31, 2023

Hi,

I thought this repo as limited to the fits standard itself, see e.g. ogadf schema for using this for a specific format

@kelle
Copy link
Author

kelle commented Mar 31, 2023

Ahhh, ok. So, I could have a module like common_headers where I could define the SpectrumHeader class and then

SpectrumHeader.verify_header('my_header')

would check both the keywords I added to the SpectrumHeader class and the keywords in the HeaderSchema? Am I understanding the way this works correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants