From 9033cb580f87f4da013cd57a5a80b0f51fedb1cf Mon Sep 17 00:00:00 2001 From: Gerald Morrison <67469729+morri-son@users.noreply.github.com> Date: Mon, 25 Nov 2024 13:49:21 +0100 Subject: [PATCH] chore(signing): correct Fulcio service to correct address (#1135) #### What this PR does / why we need it correct Fulcio service to correct address, as currecnt address leads to "no host found" when traing to sign using cosign #### Which issue(s) this PR fixes --------- Co-authored-by: Hilmar Falkenberg --- api/tech/signing/handlers/sigstore/attr/attr.go | 4 ++-- docs/reference/ocm.md | 2 +- docs/reference/ocm_attributes.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api/tech/signing/handlers/sigstore/attr/attr.go b/api/tech/signing/handlers/sigstore/attr/attr.go index da9f985573..a8cbb71d50 100644 --- a/api/tech/signing/handlers/sigstore/attr/attr.go +++ b/api/tech/signing/handlers/sigstore/attr/attr.go @@ -15,7 +15,7 @@ const ( var defaultAttr = Attribute{ // https://github.com/tektoncd/chains/blob/main/docs/config.md#keyless-signing-with-fulcio - FulcioURL: "https://v1.fulcio.sigstore.dev", + FulcioURL: "https://fulcio.sigstore.dev", RekorURL: "https://rekor.sigstore.dev", OIDCIssuer: "https://oauth2.sigstore.dev/auth", OIDCClientID: "sigstore", @@ -46,7 +46,7 @@ func (a AttributeType) Description() string { return ` *sigstore config* Configuration to use for sigstore based signing. The following fields are used. -- *fulcioURL* *string* default is https://v1.fulcio.sigstore.dev +- *fulcioURL* *string* default is https://fulcio.sigstore.dev - *rekorURL* *string* default is https://rekor.sigstore.dev - *OIDCIssuer* *string* default is https://oauth2.sigstore.dev/auth - *OIDCClientID* *string* default is sigstore diff --git a/docs/reference/ocm.md b/docs/reference/ocm.md index f99a049602..3dd9541eb2 100644 --- a/docs/reference/ocm.md +++ b/docs/reference/ocm.md @@ -309,7 +309,7 @@ The value can be a simple type or a JSON/YAML string for complex values - ocm.software/signing/sigstore [sigstore]: *sigstore config* Configuration to use for sigstore based signing. The following fields are used. - - *fulcioURL* *string* default is https://v1.fulcio.sigstore.dev + - *fulcioURL* *string* default is https://fulcio.sigstore.dev - *rekorURL* *string* default is https://rekor.sigstore.dev - *OIDCIssuer* *string* default is https://oauth2.sigstore.dev/auth - *OIDCClientID* *string* default is sigstore diff --git a/docs/reference/ocm_attributes.md b/docs/reference/ocm_attributes.md index a6e94b5d1c..af981a5bf0 100644 --- a/docs/reference/ocm_attributes.md +++ b/docs/reference/ocm_attributes.md @@ -201,7 +201,7 @@ OCM library: - ocm.software/signing/sigstore [sigstore]: *sigstore config* Configuration to use for sigstore based signing. The following fields are used. - - *fulcioURL* *string* default is https://v1.fulcio.sigstore.dev + - *fulcioURL* *string* default is https://fulcio.sigstore.dev - *rekorURL* *string* default is https://rekor.sigstore.dev - *OIDCIssuer* *string* default is https://oauth2.sigstore.dev/auth - *OIDCClientID* *string* default is sigstore