Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ConfigSet to be a string #347

Open
2 tasks
ikhandamirov opened this issue Dec 20, 2024 · 0 comments
Open
2 tasks

Change ConfigSet to be a string #347

ikhandamirov opened this issue Dec 20, 2024 · 0 comments
Labels
area/ipcei Important Project of Common European Interest kind/task small task, normally part of feature or epic

Comments

@ikhandamirov
Copy link

Description:

-	ConfigSet *string `json:"configSet"`
+	ConfigSet string `json:"configSet,omitempty"`

The change is requested here:
https://github.com/open-component-model/ocm-k8s-toolkit/pull/43#discussion_r1888680392

To remain consistent, the change needs to be done in all ocm-k8s-toolkit controllers using ConfigSet. Therefore this separate issue has been created.

Done Criteria:

  • Code has been reviewed by other team members
  • Existing tests must not break
@ikhandamirov ikhandamirov added the kind/task small task, normally part of feature or epic label Dec 20, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ipcei Important Project of Common European Interest kind/task small task, normally part of feature or epic
Projects
OCM Backlog Board
Status: 🆕 ToDo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikhandamirov