From e7764c8b9fa7ffde349d92974d17864a475303bb Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Sat, 25 Nov 2023 14:55:09 +0100 Subject: [PATCH] tests now green what remains to be done now is to make sure we make green all the tests that are currently skipped we also need to account for differences between the two --- internal/experiment/webconnectivityqa/badssl.go | 4 ++++ internal/experiment/webconnectivityqa/dnsblocking.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/internal/experiment/webconnectivityqa/badssl.go b/internal/experiment/webconnectivityqa/badssl.go index 573cec49c..3347df595 100644 --- a/internal/experiment/webconnectivityqa/badssl.go +++ b/internal/experiment/webconnectivityqa/badssl.go @@ -89,6 +89,10 @@ func badSSLWithUnknownAuthorityWithInconsistentDNS() *TestCase { }, ExpectErr: false, ExpectTestKeys: &testKeys{ + BodyLengthMatch: true, + StatusCodeMatch: true, + HeadersMatch: true, + TitleMatch: true, DNSConsistency: "inconsistent", HTTPExperimentFailure: "ssl_unknown_authority", XStatus: 9248, // StatusExperimentHTTP | StatusAnomalyTLSHandshake | StatusAnomalyDNS diff --git a/internal/experiment/webconnectivityqa/dnsblocking.go b/internal/experiment/webconnectivityqa/dnsblocking.go index fd971d6a9..ef2d70b25 100644 --- a/internal/experiment/webconnectivityqa/dnsblocking.go +++ b/internal/experiment/webconnectivityqa/dnsblocking.go @@ -21,6 +21,10 @@ func dnsBlockingAndroidDNSCacheNoData() *TestCase { }, ExpectErr: false, ExpectTestKeys: &testKeys{ + BodyLengthMatch: true, + StatusCodeMatch: true, + HeadersMatch: true, + TitleMatch: true, DNSExperimentFailure: "android_dns_cache_no_data", DNSConsistency: "inconsistent", XStatus: 2080, // StatusExperimentDNS | StatusAnomalyDNS