From d7df2514f5352bb953c33b6ced16b8434899d860 Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Wed, 24 Jan 2024 18:48:36 +0100 Subject: [PATCH] x --- internal/experiment/webconnectivitylte/analysisclassic.go | 2 +- internal/minipipeline/analysis.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/experiment/webconnectivitylte/analysisclassic.go b/internal/experiment/webconnectivitylte/analysisclassic.go index bec9dc022..eae59c41b 100644 --- a/internal/experiment/webconnectivitylte/analysisclassic.go +++ b/internal/experiment/webconnectivitylte/analysisclassic.go @@ -375,7 +375,7 @@ func analysisClassicComputeBlockingAccessible(woa *minipipeline.WebAnalysis, tk // 5.3. When the probe says dns_no_answer the control would otherwise say that // we have resolved zero IP addresses for historical reasons. In such a case, - // let's pretend also the control returned dns_no_answer. + // let's pretend that also the control returned dns_no_answer. if entry.Failure.Unwrap() == netxlite.FailureDNSNoAnswer && !entry.ControlDNSResolvedAddrs.IsNone() && entry.ControlDNSResolvedAddrs.Unwrap().Len() <= 0 { diff --git a/internal/minipipeline/analysis.go b/internal/minipipeline/analysis.go index 51ba58149..a2bac9bc4 100644 --- a/internal/minipipeline/analysis.go +++ b/internal/minipipeline/analysis.go @@ -453,7 +453,7 @@ func (wa *WebAnalysis) dnsComputeFailureMetrics(c *WebObservationsContainer) { if failure := obs.DNSLookupFailure.Unwrap(); failure != "" { // When the probe says dns_no_answer the control would otherwise say that // we have resolved zero IP addresses for historical reasons. In such a case, - // let's pretend also the control returned dns_no_answer. + // let's pretend that also the control returned dns_no_answer. if failure == netxlite.FailureDNSNoAnswer { if !obs.ControlDNSResolvedAddrs.IsNone() && obs.ControlDNSResolvedAddrs.Unwrap().Len() <= 0 { wa.DNSLookupExpectedFailure.Add(obs.DNSTransactionID.Unwrap())