From 60ebc7a6ad4e0c0aebdbe3c0bb2ad386ec78b420 Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Wed, 24 Jan 2024 18:48:00 +0100 Subject: [PATCH] x --- internal/experiment/webconnectivitylte/analysisclassic.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/experiment/webconnectivitylte/analysisclassic.go b/internal/experiment/webconnectivitylte/analysisclassic.go index c4c7653577..bec9dc022c 100644 --- a/internal/experiment/webconnectivitylte/analysisclassic.go +++ b/internal/experiment/webconnectivitylte/analysisclassic.go @@ -373,11 +373,9 @@ func analysisClassicComputeBlockingAccessible(woa *minipipeline.WebAnalysis, tk return } - // 5.3. Special case for when the probe failed with dns_no_answer and the test helper - // returned no addresses, which is its way to tell us the same error occurred but we - // need to interpret this result like the TH failed with dns_no_answer. - // - // Obviously, the TH cannot change because that would break backward compatibility. + // 5.3. When the probe says dns_no_answer the control would otherwise say that + // we have resolved zero IP addresses for historical reasons. In such a case, + // let's pretend also the control returned dns_no_answer. if entry.Failure.Unwrap() == netxlite.FailureDNSNoAnswer && !entry.ControlDNSResolvedAddrs.IsNone() && entry.ControlDNSResolvedAddrs.Unwrap().Len() <= 0 {