Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first version of TSValid is ready for review #1

Open
matentzn opened this issue Dec 2, 2021 · 0 comments
Open

The first version of TSValid is ready for review #1

matentzn opened this issue Dec 2, 2021 · 0 comments
Assignees

Comments

@matentzn
Copy link
Collaborator

matentzn commented Dec 2, 2021

@jamesaoverton

You can start from the README.md, and then take a bit of a look around if you have time. I think it would be good if you could look at the project organisation a little bit as well.

  • I have done a huge deal of work on the QC stuff, black, flake8, code cleanliness etc.
  • The encoding error check does not do what we thought it would (which is pointing out bad characters) - turns out you can stick anything into a utf-8 encoded file. We probably need to iterate over this a bit, but do have some tests in place.
  • Let's use this for a while now, and gather issues. Adding checks should be really easy at this point.

You can close this issue once you are happy with the general organisation of the code, and then we should start using the tool in our day to day work and start filing bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants