fix event hash check test #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koko1123
force-pushed
the
amlandeep/fix-event-hash-check
branch
from
76d69a3 to
fdeb0a9
Compare
peterargue
reviewed
Oct 6, 2023
state/convert_test.go
Outdated
Comment on lines
107
to
110
| if idx < txnLen { | ||
| col.txns = append(col.txns, txns[idx]) | ||
| } | ||
| col.txnResults = append(col.txnResults, result) |
There was a problem hiding this comment.
shouldn't txns and txnResults contain the same number of elements?
peterargue
reviewed
Oct 6, 2023
state/convert_test.go
Outdated
| @@ -88,24 +88,30 @@ func TestDeriveEventsHash(t *testing.T) { | |||
| client := spork.AccessNodes.Client() | |||
| for blockHeight := startBlockHeight; blockHeight < endBlockHeight; blockHeight++ { | |||
| block, err := client.BlockByHeight(ctx, blockHeight) | |||
| txns, err := client.TransactionsByBlockID(ctx, block.Id) | |||
| assert.NoError(t, err) | |||
There was a problem hiding this comment.
nit, many of these assert.NoError should really be require.NoError. require aborts the test immediately if it's false, which is appropriate if the condition must be true for the rest of the test to be valid.
peterargue
approved these changes
Oct 6, 2023
zhangchiqing
approved these changes
Oct 6, 2023
gomisha
added a commit
that referenced
this pull request
Oct 19, 2023
* initial test * using master branch of flow-go, updated deps to latest versions * fixed localnet bootstrap target, added docs * opentelemetry package updates (WIP) * opentelemetry package updates (done) * opentelemetry attribute option fix * opentelemetry attribute option fix 2 * reverted integration_test.py to mostly original * update localnet access node port * update hash version for localnet * reverted skipping hash check of chunk event collection * account creation using benchnet2 network * deploy contract using benchnet2 network * fix event hash check test (#46) * correct test case and revert original Event hash check * push * modify event hash testy * update tests for canary * correct block range * correct access addr * replicate block hash issue * fix block hash in test * change assert usage * update emulator chain ID to flow-benchnet * check commented out: mismatching event hash within chunk * emulator network support added (for BN2) * updated to latest version of flow, BN2 network * clean up --------- Co-authored-by: Amlandeep Bhadra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45