Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLP Implementation #221

Open
sideninja opened this issue Oct 19, 2021 · 3 comments · May be fixed by #290
Open

RLP Implementation #221

sideninja opened this issue Oct 19, 2021 · 3 comments · May be fixed by #290

Comments

@sideninja
Copy link
Contributor

Currently, the SDK uses RLP implementation from go-ethereum package which is huge!. I believe we would benefit from implementing RLP ourselves since that big dependency would be removed. Also RLP is something that wouldn't change.

@sideninja
Copy link
Contributor Author

There has been some work done for RLP integration in flow-go onflow/flow-go#2011
Keep an 👁️ on it

@sideninja sideninja added the L3 label Feb 23, 2022
@jwinkler2083233
Copy link

jwinkler2083233 commented Feb 23, 2022

I agree with you 100%, from a performance perspective. RLP only requires about 8 code files, plus tests.

In addition to the heap thrashing addressed in onflow/flow-go#2011, the use of reflection and heap for walking the object graph is worth avoiding. Other forums online have suggested creating a kind of IDL -- a parser that will generate the appropriate code for generating struct and data object graph serialization. It's actually not hard to do, so it's on the radar. It would be much better if RLP code were forked (or appropriated somehow) to make this happen.

@sideninja
Copy link
Contributor Author

Is there any plan in the flow-go to do that? The forking/our implementation?

@sideninja sideninja linked a pull request Jun 6, 2022 that will close this issue
8 tasks
@sideninja sideninja moved this to 🏗 In progress in 🌊 Flow 4D Mar 30, 2023
@sideninja sideninja added the Good First Issue Good for newcomers label Aug 4, 2023
@gregsantos gregsantos moved this from 🏗 In Progress to 🧊 Backlog in 🌊 Flow 4D Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧊 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants