You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the SDK uses RLP implementation from go-ethereum package which is huge!. I believe we would benefit from implementing RLP ourselves since that big dependency would be removed. Also RLP is something that wouldn't change.
The text was updated successfully, but these errors were encountered:
I agree with you 100%, from a performance perspective. RLP only requires about 8 code files, plus tests.
In addition to the heap thrashing addressed in onflow/flow-go#2011, the use of reflection and heap for walking the object graph is worth avoiding. Other forums online have suggested creating a kind of IDL -- a parser that will generate the appropriate code for generating struct and data object graph serialization. It's actually not hard to do, so it's on the radar. It would be much better if RLP code were forked (or appropriated somehow) to make this happen.
Currently, the SDK uses RLP implementation from
go-ethereum
package which is huge!. I believe we would benefit from implementing RLP ourselves since that big dependency would be removed. Also RLP is something that wouldn't change.The text was updated successfully, but these errors were encountered: