-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX(make): fix incremental builds by only releasing updated headers #2949
Open
ahuber21
wants to merge
10
commits into
oneapi-src:main
Choose a base branch
from
ahuber21:dev/ahuber/fix-incremental-builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FIX(make): fix incremental builds by only releasing updated headers #2949
ahuber21
wants to merge
10
commits into
oneapi-src:main
from
ahuber21:dev/ahuber/fix-incremental-builds
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuber21
force-pushed
the
dev/ahuber/fix-incremental-builds
branch
from
October 23, 2024 08:04
222206f
to
2c4652d
Compare
/intelci: run |
Thanks @Alexsandruss. It was still a draft, but the latest changes seem to fix the issue and don't add any new spaces. |
Co-authored-by: Alexander Andreev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a check using the
cmp
command in the macros responsible for publishing header files from theinclude
directory to the__release_*
directories. With this enhancement, headers are only released if their contents have changed.This improvement addresses an issue with make's caching mechanism, which relies on file timestamps. Previously, central header files like
library_version_info.h
were released every time make was invoked, regardless of whether their contents had changed. This caused the timestamps to always be newer than those of the source files, triggering unnecessary target updates and negating the benefits of incremental builds.With the proposed changes, only files that have actually changed (along with their dependencies) will be rebuilt, thereby preserving the efficiency of incremental builds.
Fixes #2944
and probably also #632
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
does not apply - build chain only
Performance
does not apply - build chain only