-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Improved SignPSBT method #286
Comments
yo @JakeFernandes98 dope! this looks like a good idea. lemme ask, how would that affect the buy sell systems if the wallet doesn't provide such specificity? |
Side note: I know you're currently working on signMultipleTransactions/signPsbts which suffers from the same issue (some wallets support some don't). Perhaps implementing some 'Capability' object to each wallet and relevant methods (getCapabilities, hasCapability) may help developers navigate these disparities with wallets. We have something like this in our custom implementation.
|
@JakeFernandes98 so as it stands, for the wallets that support it, we track down the inputs needed to sign during the signature. here's an example: |
This should work in principle. Will test and come back to you |
Is your feature request related to a problem?
No
Describe the solution you'd like
Currently signPSBT takes in a psbt hex, with no control over which input(s) to sign. The sats connect library gives a good overview on how this could be designed.
https://docs.xverse.app/sats-connect/bitcoin-methods/signpsbt
Additional context
Working on a runes marketplace, the feature is critical to the implementation of rune buy/sell systems.
The text was updated successfully, but these errors were encountered: