Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple response types #83

Closed
tgunaselan opened this issue Mar 25, 2021 · 10 comments
Closed

Support for multiple response types #83

tgunaselan opened this issue Mar 25, 2021 · 10 comments
Labels

Comments

@tgunaselan
Copy link

Currently, response_type can be either code or id_token.

Does this gem have support for multiple-valued response types, such as id_token token?

If so, what is the correct format for specifying them in the config? If not, can this functionality be added?

See the following for references:

https://openid.net/specs/openid-connect-core-1_0.html#Authentication

@tgunaselan
Copy link
Author

tgunaselan commented Mar 25, 2021

For implicit and hybrid flow, enabling "token" along with code/id_token would be much helpful

@tgunaselan
Copy link
Author

Any Update.

@tgunaselan
Copy link
Author

Hello, Is this request need any further reasons or inputs from my end ?

@tgunaselan
Copy link
Author

Pinging here to enable this request open.

@stale
Copy link

stale bot commented Jul 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 17, 2021
@stale stale bot closed this as completed Jul 24, 2021
@gwright
Copy link

gwright commented Oct 5, 2021

I'd like to reopen this topic. I'm looking to implement the hybrid flow ("code id_token") and that fails with the current version of the gem the #valid_response_type? method because it assumes a single configured value for response_type. I'm not sure if that is the only difficulty but I'm going to see if I can get this to work in a fork.

@kreintjes
Copy link

Same problem over here. Our provider recommends the hybrid flow ("code id_token") in our situation. We cannot currently achieve this with this gem. Is there any solution for this or are there plans to implement this?

@davidwessman
Copy link
Contributor

I do not think anyone is working actively unless it is for their own usage.
So please try to make a PR 🙂

@davidwessman
Copy link
Contributor

I guess this is what you are looking for?
#139

Maybe try it out, see if it works for you?

@kreintjes
Copy link

Ah nice, missed that one. Good thing it is mentioned here now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants