-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec naming style #54
Comments
We should absolutely have a consistent naming style. I would personally vote for snake case (python style) but I don't have a strong opinion and camel case (java style) would also be fine with me. |
I agree with @constantinpape (1. snake case, 2. camelCase) with a rather strong rejection of the "postion-x" just because I know I'll have to parse out the dash sign at some point and I'm lazy, and a very strong rejection of "positionx" because it will be confusing with e.g. the curvilinear coordinate "s" |
Similar to the "dashes don't work great in programming languages", I'd add that casing isn't always that clear with URLs. Since I expect these identifiers will eventually get used in such contexts, I'd favor |
If we wish to follow the style in place in schema.org, |
From comment on ome/omero-cli-render#55 My comment is more general that this specific issue. The suggestion of following schema.org is coming from the fact that others efforts e.g. bioschema.org, ro-crate follow that convention so it might make more sense to follow similar rule instead of the |
see also https://www.ebi.ac.uk/spot/oxo/docs/api (ontologies related) |
Given ongoing PRs in #57 etc. it would be good to come to a decision here. Given the usage of |
@glyg had the strongest objection in #54 (comment). I'm personally tend towards underscores (i.e. more PEP8) |
I read #54 (comment) as being fine with both camel or snake case, just objecting (rightfully in my opinion) to |
Ah, I see. I misread. |
Hi, I feel @constantinpape argument for camel case as being already in use at schema.org wins - my python tropism maybe clouds my judgement :) - I guess you can always work around the lowercase url issue? |
I don't know if we're actually going to use schema.org, but it seems that many schemas and data-models tend to use |
Opened a PR at #70 to add the |
When looking to add new keys to the spec I wonder how to name e.g. position_x I wonder what the naming style should be e.g.
Looking at the current spec, we have all of these styles there already, reflecting the origin of various terms (mea culpa):
image-label
defaultT
- Rendering definition (omero). to be replaced by rendering spec?maximumfieldcount
- HCS, to be replace by Collections specfield_count
- Also HCS.So, which of these do we prefer? Python style, Java style or something else?
The text was updated successfully, but these errors were encountered: