Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuskript crashes when attempting search #1313

Open
iww-clydeside opened this issue Aug 11, 2024 · 3 comments
Open

Manuskript crashes when attempting search #1313

iww-clydeside opened this issue Aug 11, 2024 · 3 comments
Labels

Comments

@iww-clydeside
Copy link

We have a small (ish) document and a large one. On both Manuskript has crashed whenever I use the search function. I couldn't find an open issue for this, I did try to check.

On debian bookworm.

@ByteOfBrie
Copy link
Contributor

Based on the package list, debian bookworm uses Manuskript 0.14

I found #1218, which could be related, since it's fixed in a newer version, but it's hard to tell without logs. If you can attach those, that would be useful. See step three here

@iww-clydeside
Copy link
Author

It is turning up intermittently. Sometimes it works sometimes it doesn't. I can't figure out which log file contains the error so I've attached all of the ones from yesterday.
2024-08-12_01-12-56_manuskript#3108.log
2024-08-12_05-56-03_manuskript#3118.log
2024-08-12_12-07-06_manuskript#39958.log

@ByteOfBrie
Copy link
Contributor

Thanks for providing the logs!

The crash happens in the last log file:

2024-08-12 17:56:04,641 - manuskript.logging - CRITICAL - An unhandled exception has occurred!
Traceback (most recent call last):
  File "/usr/share/manuskript/manuskript/ui/search.py", line 142, in search
    results += model.searchOccurrences(searchRegex, filteredColumns)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/manuskript/manuskript/models/searchableModel.py", line 11, in searchOccurrences
    results += item.searchOccurrences(searchRegex, column)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/manuskript/manuskript/models/plotModel.py", line 322, in searchOccurrences
    results += super().searchOccurrences(searchRegex, column)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/manuskript/manuskript/models/searchableItem.py", line 16, in searchOccurrences
    return [self.wrapSearchOccurrence(column, startPos, endPos, context) for (startPos, endPos, context) in search(searchRegex, self.searchData(column))]
                                                                                                                                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/manuskript/manuskript/models/plotModel.py", line 354, in searchData
    return self.getItem(self.rowIndex, column).text()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'text'

And this provides more information on the issue. It's definitely the same issue as before, which was fixed in 1fd8762.

Looking at the logs, you're on version 0.15, and the linked fix isn't included before 0.16

If you manage to run Manuskript through source, or get a newer version installed, that should be enough to fix it. The version in debian repositories is old, but the download page for Manuskript has instructions for installing version 0.16.1 on debian: https://www.theologeek.ch/manuskript/download/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants