Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover state consistency in the Modals/Dialogs across the ODE #596

Open
Faithkenny opened this issue Oct 14, 2024 · 3 comments · May be fixed by #620
Open

Hover state consistency in the Modals/Dialogs across the ODE #596

Faithkenny opened this issue Oct 14, 2024 · 3 comments · May be fixed by #620
Assignees

Comments

@Faithkenny
Copy link
Collaborator

Overview

The ODE has both OneButton dialog and TwoButton modals. This is the current list of the regularized, and updated existing modals.

Except the Delete modal, they all have their primary button color as OKFN/black button, and hovers to the OKFN/Blue. The secondary action (usually Cancel) has a gray outline button, and hovers to a gray filled button

@romicolman
Copy link
Collaborator

Thank you, @Faithkenny. The Rename feature has not been implemented yet. It was not part of the pre-release.

@guergana: this is connected to this ticket #526. The list is for hover state consistency.

Changes:

Add external data/Launch screen /How the ODE saves your data : In the current version of the ODE, buttons in these dialogs turn blue once the user pastes the link. To standardize buttons, they should turn black instead. Implementing this will align hover state consistency with the Publish, Unsaved changes and Create folder dialogs (Ticket #526).

@guergana guergana linked a pull request Oct 30, 2024 that will close this issue
@romicolman
Copy link
Collaborator

romicolman commented Oct 31, 2024

Hi @guergana! My comment regarding the rename feature was linked to the fact that at the time I wrote it, the Rename feature had not been implemented yet (2 weeks ago. See issue #609).

Let me know if you have further questions regarding changes. We can have a short call to clarify them.

@Faithkenny
Copy link
Collaborator Author

@guergana

Delete modal - file & Prototype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code review
Development

Successfully merging a pull request may close this issue.

3 participants