Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable require-await eslint rule #1058

Closed
taoeffect opened this issue Mar 25, 2021 · 0 comments · Fixed by #1059
Closed

Enable require-await eslint rule #1058

taoeffect opened this issue Mar 25, 2021 · 0 comments · Fixed by #1059
Labels
App:Backend App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Starter

Comments

@taoeffect
Copy link
Member

Problem

Per #1052 (comment)

There are apparently several places where async is used to describe a function with no corresponding await.

This can create confusion as to what the return value is supposed to be (e.g. a promise or a raw value) and could lead to bugs.

Solution

Add require-await and fix all existing errors, making sure to double-check the return values are properly handled when async is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App:Backend App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Level:Starter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant