Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Make core app independent of georeference app #248

Open
3 of 5 tasks
mradamcox opened this issue Jan 23, 2025 · 0 comments
Open
3 of 5 tasks

[Task] Make core app independent of georeference app #248

mradamcox opened this issue Jan 23, 2025 · 0 comments

Comments

@mradamcox
Copy link
Collaborator

mradamcox commented Jan 23, 2025

Describe the task
The core app should have migrations that do not depend on any other app. Currently, the LayerSet model is in the georeference app, where it made sense to put it at the time it was created. However, it should be moved within the core app. Similarly, core.Region has a foreign key to georeference.GCPGroup but that relationship can be reversed.

Completion criteria

  • New LayerSet model in the core app created
  • Copy all existing objects to that model, update code
  • Remove LayerSet from georeference app
  • Create ForeignKey on georeference.GCPGroup to relate to core.Region and populate with all existing values.
  • Update code, then remove existing core.Region.gcp_group relationship

Additional context
This reorganization makes more sense thematically, as LayerSet is just a group of Layers and needs to have a first-class (in-app) connection back to the Map model which is in the core app. More importantly, this should make proper squashing of the existing migrations #205 (which will elide models that have been created and later deleted) possible. This ticket overall will finally, properly, complete the migration to the new data model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant