twisted 22 / removal of several old functions

[jbleyel]

https://github.com/twisted/twisted/releases/tag/twisted-22.1.0rc1
->

Deprecations and Removals

twisted.web.client.getPage, twisted.web.client.downladPage, and the associated implementation classes (HTTPPageGetter, HTTPPageDownloader, HTTPClientFactory, HTTPDownloader) have been removed because they do not segregate cookies by domain. They were deprecated in Twisted 16.7.0 in favor of twisted.web.client.Agent. GHSA-92x2-jw7w-xvvx. (#10295)

[jbleyel]

We have several options for twisted.web.client.getPage and twisted.web.client.downladPage

• urllib.request
• requests
• treq
• twisted Agent

I'm not sure what's the best case.

PRO/CONS are welcome.

[TwolDE2]

Personally hate twisted as its a pain to debug. E2m3u2bouquet was changed to requests and works fine…there are a couple of other modules that use requests (if I could remember which!)
Have you checked which plugins use twisted getpage etc?

[TwolDE2]

XLMTV-import is one, so this is an issue

[jbleyel]

requests or urllib is blocking the UI and twisted getPage is using a background thread.

That's why i prefer treq as a replacement.

[TwolDE2]

treq looks good, and based around requests api.