Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize catalog format before using it further (in particular for job id) #345

Open
volodymyrss opened this issue Feb 3, 2022 · 2 comments · May be fixed by #346
Open

normalize catalog format before using it further (in particular for job id) #345

volodymyrss opened this issue Feb 3, 2022 · 2 comments · May be fixed by #346
Assignees
@burnout87 @volodymyrss
Milestone
v22.09.0001

Comments

@volodymyrss
Copy link
Member

example of two versions of almost the same catalog are here https://github.com/oda-hub/doc-review-guidelines/issues/74

Some transformations should be made to make them the same.
@burnout87
Copy link
Collaborator

Is there a place where the standard format of a catalog, that we want, is defined?

For example, is this one a good reference?

@volodymyrss
Copy link
Member Author

Is there a place where the standard format of a catalog, that we want, is defined

There is not a generic format.

For example, is this one a good reference?

It's a table. Catalog is a table with specific columns and types.

Let's just make a function that converts both examples given in https://github.com/oda-hub/doc-review-guidelines/issues/74 to the same form. It could be delicate in general since it can change the meaning of the catalog. But it's clear in this case.

Or you could make a placeholder and I finalize the conversion function preserving the meaning.

@burnout87 burnout87 linked a pull request Feb 4, 2022 that will close this issue
catalog normalization function placeholder #346
Draft
@volodymyrss volodymyrss added this to the v22.02.0000 milestone Feb 7, 2022
@volodymyrss volodymyrss self-assigned this Feb 14, 2022
@volodymyrss volodymyrss modified the milestones: v22.07.0000, v22.07.0001 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burnout87 burnout87

@volodymyrss volodymyrss

Labels
None yet
Projects
None yet
Milestone
v22.09.0001
Development

Successfully merging a pull request may close this issue.

catalog normalization function placeholder oda-hub/dispatcher-app
2 participants
@burnout87 @volodymyrss