Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Banner images are all whited-out #1425

Open
trentmc opened this issue Mar 19, 2024 · 2 comments
Open

[UX] Banner images are all whited-out #1425

trentmc opened this issue Mar 19, 2024 · 2 comments
Labels
Type: Bug Something isn't working

Comments

@trentmc
Copy link
Member

trentmc commented Mar 19, 2024

The problem

Banner (cover) image for each README is weirdly whited-out. This makes it feel poorer-quality, and inconsistent with images below which aren't whited-out or muted in some other fashion. AFAIK this is recent; it wasn't like that a couple months ago.

Some examples are below.

Root cause

(Found via 'inspect' in chrome): It's adding inside tag for the cover image: class="w-full object-cover object-center [mask-image:linear-gradient(rgba(0,0,0,1),_rgba(0,0,0,0.5))] block"

But gitbook doesn't make it easy to remove this. (Details in comment below.)

Possible solutions

Ideally: find a way to not have the whiteout

In lieu of that, other options per page are:

  • don't have a cover image. Note: this is where main page is headed, see #1423
  • have an inline image, vs cover image. Example: see Cand 0 in a #1423 comment.

Examples

Main

Discover

Developers

@trentmc trentmc added the Type: Bug Something isn't working label Mar 19, 2024
@trentmc
Copy link
Member Author

trentmc commented Mar 19, 2024

Datapoints on whited-out image...

  1. The png splash image is in .gitbook/assets/cover/docs_banner.png. It's not whited out. Here's a copy:
  1. The gitbook "spaces page" rendering is not whited out either:
    https://app.gitbook.com/o/mTcjMqA4ylf55anucjH8/s/zQlpIJEeu8x5yl0OLuXn/
  1. Recall that screenshots in the description (with whited-out) were on macos chrome. What about other browsers? Here's macos firefox. It's whited-out too.
  1. Here's ios chrome. It's whited-out too.
  1. Q: does the PR preview show whited-out? A: yes
    https://docs.oceanprotocol.com/~/revisions/sFqCS3PKcw0DBTcDVVfi
  1. Q: is dark-mode whited-out? Experiment: Go to oceanprotocol.com, bottom-right, and toggle dark-mode. Result: not whited-out

Summary: whited out at (everywhere to users or staging) x lightmode.

@trentmc
Copy link
Member Author

trentmc commented Mar 19, 2024

More on the whiteout: It's inserting this inside <image> tag for the cover image: class="w-full object-cover object-center [mask-image:linear-gradient(rgba(0,0,0,1),_rgba(0,0,0,0.5))] block"

But gitbook doesn't make it easy to remove this.

Details:

Via chrome inspection:
with mask-image

With chrome, we can locally remove this:
removed mask-image in local html


Here's the css code (on the right)
what-css

Q: Will gitbook let you change css? Answer 1 from searching docs: "no" across the board
gitbook-css

Q: Will gitbook let you change css? Answer 2 from google search: "no" for cover images, "yes" for other images (ie inline images). Since we care about cover images, no?
https://docs.gitbook.com/content-editor/blocks/insert-images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant