Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] trace (4 packages) (0.9) #27259

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

c-cube
Copy link
Contributor

@c-cube c-cube commented Jan 13, 2025

A stub for tracing/observability, agnostic in how data is collected

CHANGES:
  • add an extensible sum type, so users can implement custom events. For example
    an OTEL collector can provide custom events to link two spans to one another.

@raphael-proust
Copy link
Contributor

Not sure if it's a transient error of the CI but there's currently 404s everywhere. I'vecancelled the build for now.

@raphael-proust
Copy link
Contributor

well there's no 0.9 in https://github.com/c-cube/ocaml-trace/tags nor in releases

so that's probably it

@c-cube
Copy link
Contributor Author

c-cube commented Jan 13, 2025

I reuploaded it. Must have forgotten the dune-release publish step.

CHANGES:

- add an extensible sum type, so users can implement custom events. For example
    an OTEL collector can provide custom events to link two spans to one another.
@c-cube c-cube force-pushed the release-trace-v0.9 branch from 172e9e6 to 42543b3 Compare January 13, 2025 19:14
@shonfeder
Copy link
Contributor

Looks to me like these revedeps failures for opentelemetry may be related?

compilers

4.14
trace.0.9
revdeps
opentelemetry.0.10 (failed: Signature mismatch:)
opentelemetry.0.9 (failed: Signature mismatch:)
5.3
trace.0.9
revdeps
opentelemetry.0.10 (failed: Signature mismatch:)
opentelemetry.0.9 (failed: Signature mismatch:)

# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlopt.opt -w -40 -warn-error -a+8 -w +a-4-30-40-41-42-44-48-70 -strict-sequence -g -I src/trace/.opentelemetry_trace.objs/byte -I src/trace/.opentelemetry_trace.objs/native -I /home/opam/.opam/5.3/lib/ambient-context -I /home/opam/.opam/5.3/lib/ambient-context/atomic -I /home/opam/.opam/5.3/lib/ambient-context/core -I /home/opam/.opam/5.3/lib/ambient-context/thread_local -I /home/opam/.opam/5.3/lib/ambient-context/tls -I /home/opam/.opam/5.3/lib/hmap -I /home/opam/.opam/5.3/lib/ocaml/threads -I /home/opam/.opam/5.3/lib/ocaml/unix -I /home/opam/.opam/5.3/lib/pbrt -I /home/opam/.opam/5.3/lib/ptime -I /home/opam/.opam/5.3/lib/ptime/clock -I /home/opam/.opam/5.3/lib/trace/core -I src/atomic/.opentelemetry_atomic.objs/byte -I src/atomic/.opentelemetry_atomic.objs/native -I src/core/.opentelemetry.objs/byte -I src/core/.opentelemetry.objs/native -I src/proto/.opentelemetry_proto.objs/byte -I src/proto/.opentelemetry_proto.objs/native -intf-suffix .ml -no-alias-deps -o src/trace/.opentelemetry_trace.objs/native/opentelemetry_trace.cmx -c -impl src/trace/opentelemetry_trace.ml)
# File "src/trace/opentelemetry_trace.ml", line 276, characters 46-56:
# 276 | let collector () : Otrace.collector = (module Internal.M)
#                                                     ^^^^^^^^^^
# Error: Signature mismatch:
#        ...
#        The value "extension_event" is required but not provided
#        File "src/core/collector.ml", line 97, characters 2-47:
#          Expected declaration

I think from this addition: c-cube/ocaml-trace@4dfa319#diff-200ef699c03562ccea70000ac13fe48441941739e0c1bc622abd8dca5eb24c3eR97

I'll add the upper bound here, then we should be good to go :)

@shonfeder
Copy link
Contributor

Merging since the opentelemetry tests and revdeps are now passing, and all other checks were good or irrelevant before.

@shonfeder shonfeder merged commit 26328df into ocaml:master Jan 14, 2025
2 of 3 checks passed
@c-cube
Copy link
Contributor Author

c-cube commented Jan 14, 2025

Thank you :)

@c-cube c-cube deleted the release-trace-v0.9 branch January 14, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants