Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--dry-run unexpectedly force pushes to existing PR #117

Open
leviroth opened this issue Dec 13, 2020 · 1 comment
Open

--dry-run unexpectedly force pushes to existing PR #117

leviroth opened this issue Dec 13, 2020 · 1 comment

Comments

@leviroth
Copy link

I created a PR with opam publish and ran into some CI issues, so I made changes to my project and was trying to figure out how to modify the PR. I tried opam publish --dry-run, hoping that I could somehow export the patch to my fork of opam-repository.

In fact, opam publish --dry-run force pushed the new packages to the remote branch underlying my existing PR.

While this is ultimately what I was trying to do, it's unexpected that --dry-run results in world-visible changes like this.

@yannl35133
Copy link

More generally, it looks like opam-publish doesn't properly take into account when you are trying to amend an existing PR, and so every call to it will force-push with no prior warning to the user.
I intended to push the modifications in the form of a new commit, which is what I think opam-publish should offer to do, but at least put it behind a confirmation prompt.

(My message looks blunt now that I read it, the tool is still good and very useful, I'd still much rather use it than learn how to publish manually, so thank you devs for it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants