Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin: MCP Tools #5101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add plugin: MCP Tools #5101

wants to merge 3 commits into from

Conversation

jacksteamdev
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/jacksteamdev/obsidian-mcp-tools

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 9, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 21, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Jan 23, 2025

# Obsidian MCP Tools
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header and any other strings like this.

basePath: string;
This is not defined on the DataAdapter interface, it only exists on desktop.
Instead of this, do a adapter instanceof FileSystemAdapter check, then use the public getBasePath() function on it.

Install Server, Installing MCP Server..., Uninstalling MCP Server..
Use sentence case in UI

@joethei joethei self-assigned this Jan 23, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 23, 2025
@jacksteamdev jacksteamdev mentioned this pull request Jan 25, 2025
Merged
@jacksteamdev
Copy link
Author

jacksteamdev commented Jan 25, 2025 •
edited
Loading

@joethei Thanks for the feedback! You may find the changes you requested in release 0.2.22:

  1. Plugin name in the README is now MCP Tools for Obsidian

  2. FileSystemAdapter check lives in getFileSystemAdapter()

  3. UI has been updated to use sentence case:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joethei joethei

@ObsidianReviewBot ObsidianReviewBot

Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacksteamdev @ObsidianReviewBot @joethei