Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bars shouldn’t disappear if there are too many of them. #72

Closed
Fil opened this issue Dec 23, 2020 · 2 comments · Fixed by #306
Closed

Bars shouldn’t disappear if there are too many of them. #72

Fil opened this issue Dec 23, 2020 · 2 comments · Fixed by #306
Assignees
@Fil
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Dec 23, 2020

No description provided.

Fil added a commit that referenced this issue Dec 23, 2020
@Fil
never round scales that would result in 0 bandwidth
d55a599 
fixes #72
@Fil Fil mentioned this issue Dec 23, 2020
Closed
Fil added a commit that referenced this issue Dec 23, 2020
@Fil
an heuristic to prevent tick occlusion
a1a5330 
Related: #72
@Fil Fil mentioned this issue Dec 23, 2020
Closed
@mbostock mbostock added the bug Something isn’t working label Feb 24, 2021
@mbostock mbostock added this to the Friends Preview milestone Feb 24, 2021
@mbostock
Copy link
Member

This arguably isn’t a bug, but given that round defaults to true for band scales I think we should do something to address this risk. Not sure what… there’s kind of a similar issue with tick rendering with high-cardinality ordinal domains.

@Fil Fil self-assigned this Mar 3, 2021
@mbostock mbostock removed this from the Friends Preview milestone Mar 10, 2021
@Fil
Copy link
Contributor Author

Fil commented Mar 31, 2021

We should do this in d3-scale d3/d3-scale#243

@Fil Fil mentioned this issue Apr 8, 2021
Merged
@mbostock mbostock mentioned this issue Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fil Fil

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
2 participants
@Fil @mbostock