Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mAP evaluation #91

Open
oarriaga opened this issue Sep 8, 2020 · 0 comments
Open

Refactor mAP evaluation #91

oarriaga opened this issue Sep 8, 2020 · 0 comments
Assignees
@mohanrobotics
Labels
enhancement New feature or request

Comments

@oarriaga
Copy link
Owner

oarriaga commented Sep 8, 2020

Currently as stated in #83 the compute_matches, calculate_relevance_metrics and calculate_average_precision are very long functions.

We would like to separate them into smaller functions. A good rule of thumb would be to separate them into functions where each function does one thing and it's approximately 6 to 8 lines long. Also unit-test for all new functions should be added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanrobotics mohanrobotics

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oarriaga @mohanrobotics