-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create VM Wizard- create disks storage domain issues #1366
Comments
This ends up being a bug on the REST api where it required ALL disks to be specified on the create request, not just disks that needed modification. I've addressed this, along with a bit of missing business logic, in patch 114092 for ovirt-engine's rest api. |
PR #1400 should solve bullet point 1. |
Fixes: oVirt#1366 Creating a VM from a template with disks defined, and if the disks need to be cloned to a new storage domain, navigation buttons needed to be enabled differently. Now, once on the storage domain wizard step: - The forward button is enabled ONLY when all of the disks are correct and no edit is active. - The back button is always enabled, including when: - an edit is active - no storage domain is available for the template disks - disk storage domains must be selected, but have not yet been selected (i.e. edits are active) When no storage domains are available, and no disks have been defined by the selected template, the `EmptyState` place holder will now show a "cannot create a disk" message. This message replaces the "Create Disk" button.
Fixes: oVirt#1366 Creating a VM from a template with disks defined, and if the disks need to be cloned to a new storage domain, navigation buttons needed to be enabled differently. Now, once on the storage domain wizard step: - The forward button is enabled ONLY when all of the disks are correct and no edit is active. - The back button is always enabled, including when: - an edit is active - no storage domain is available for the template disks - disk storage domains must be selected, but have not yet been selected (i.e. edits are active) When no storage domains are available, and no disks have been defined by the selected template, the `EmptyState` place holder will now show a "cannot create a disk" message. This message replaces the "Create Disk" button.
This is a follow up issue for an already merged PR #1323 regarding storage domains management during a creation of a VM with disks (original commect: #1323 (comment)):
1. When creating a VM based on a template while the template includes more than 1 disk and is optimized to "server" or a clone is required due to SD permissions then the following error still occurs:
"CREATE_VM failed [Cannot add VM. One or more provided storage domains are either not in active status or of an illegal type for the requested operation.]"
This was already mentioned above on issue 3 of #1323 (comment) and claimed to be fixed:
2. when there are no permissions for all SDs , both previous and next buttons are disabled:
3. when there are no permissions for a template disks SD and the user can choose a different SD, the previous button is disabled till all SD are selected. This is wrong:
4. when the user tries to create a disk not based on a template and there are no permissions for current SDs, the SD field is marked as red and buttons are disabled, but no message is displayed:
The text was updated successfully, but these errors were encountered: