Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last day of period isn't displayed in calendar #93

Open
tthoeye opened this issue Oct 1, 2015 · 3 comments
Open

Last day of period isn't displayed in calendar #93

tthoeye opened this issue Oct 1, 2015 · 3 comments
Labels

Comments

@tthoeye
Copy link

tthoeye commented Oct 1, 2015

...when end hour is not set after 9 AM.

This bug relates to #87

@tthoeye
Copy link
Author

tthoeye commented Oct 4, 2015

@tthoeye
Copy link
Author

tthoeye commented Oct 5, 2015

And: http://fullcalendar.io/wiki/Upgrading-to-v2/

So our options are:

  • Overriding all "allday" events to extend end date with one day autmatically
  • Patching fullcalendar (oh god please no) to make end date inclusive again

@Bertware @dorienmarinus @mietcls @dmadigipolis Ideas? Alternatives?

@Bertware
Copy link
Member

Bertware commented Oct 5, 2015

Overriding alldray events on store seems like the easiest fix. I don't know if we can do this by adding code logic to the laravel save() method? (so when it's saved, a check is performed to see if it's allday, and one day is added).
Another option is to catch this in the controllers, and add a day before calling save().

@Bertware Bertware added the bug label Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants