Rename `Delays::generate()` function (or create multiple options) to make it more obvious what kind of unit it expects #42

jstuczyn · 2020-01-31T14:30:11Z

Line 31 in 8424f4b

pub fn generate(number: usize, average_delay: f64) -> Vec<Delay> {

jstuczyn · 2020-01-31T14:31:08Z

Currently, apart from going into the source code, it isn't obvious that it expects the 'average_delay' to be in seconds. Perhaps the most generic approach would be to make it accept time::Duration ?

jstuczyn mentioned this issue Jan 31, 2020

Ability to generate vector of Delays from average time::Duration #43

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `Delays::generate()` function (or create multiple options) to make it more obvious what kind of unit it expects #42

Rename `Delays::generate()` function (or create multiple options) to make it more obvious what kind of unit it expects #42

jstuczyn commented Jan 31, 2020

jstuczyn commented Jan 31, 2020

Rename Delays::generate() function (or create multiple options) to make it more obvious what kind of unit it expects #42

Rename Delays::generate() function (or create multiple options) to make it more obvious what kind of unit it expects #42

Comments

jstuczyn commented Jan 31, 2020

jstuczyn commented Jan 31, 2020

Rename `Delays::generate()` function (or create multiple options) to make it more obvious what kind of unit it expects #42

Rename `Delays::generate()` function (or create multiple options) to make it more obvious what kind of unit it expects #42