Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers are binary different per extraction method #14

Open
jnovack opened this issue Jul 25, 2018 · 1 comment
Open

Headers are binary different per extraction method #14

jnovack opened this issue Jul 25, 2018 · 1 comment

Comments

@jnovack
Copy link
Member

jnovack commented Jul 25, 2018

From JS Extraction:

{ m_signature: 'Heroes of the Storm replay\u001b11',
  m_version:
   { m_flags: 1,
     m_major: 2,
     m_minor: 35,
     m_revision: 0,
     m_build: 66488,
     m_baseBuild: 66488 },
  m_type: 2,
  m_elapsedGameLoops: 19371,
  m_useScaledTime: false,
  m_ngdpRootKey: { m_data: '�(���c�/�u���#��' },
  m_dataBuildNum: 66488,
  m_replayCompatibilityHash:
   { m_data: '\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000' } }

From storm-replay Extraction:

{ m_signature: 'Heroes of the Storm replay\u001b11',
  m_version:
   { m_flags: 1,
     m_major: 2,
     m_minor: 35,
     m_revision: 0,
     m_build: 66488,
     m_baseBuild: 66488 },
  m_type: 2,
  m_elapsedGameLoops: 19371,
  m_useScaledTime: false,
  m_ngdpRootKey: {},
  m_dataBuildNum: 66488 }
@jnovack
Copy link
Member Author

jnovack commented Jul 25, 2018

It seems that any .m_data key is not fully processed by the storm-replay parser (e.g. m_ngdpRootKey and m_replayCompatibilityHash.

As these are currently garbage fields, I do not see much of an issue. But will leave this open as a known issue.

@nydus nydus locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant