Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label dropdown fixes #5831

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Label dropdown fixes #5831

merged 1 commit into from
Jan 30, 2025

Conversation

ericnewcomer
Copy link
Member

This fixes three issues

  • Adds inner scroll for those with many labels
  • Fixes dropdown arrow alignment when toggle slot is narrow (case with labels)
  • Tweaks padding settings for root levels menu icons so notifications is in line with other icons

#gear-container .button-light.dropdown-toggle:hover .icon-menu {
background: var(--color-primary-dark);
color: #fff !important;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused and was causing me confusion

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6d30adc) to head (c5af50e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5831   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          463       463           
  Lines        25178     25178           
=========================================
  Hits         25178     25178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericnewcomer
Copy link
Member Author

@rowanseymour looking to merge this..

@rowanseymour rowanseymour merged commit f859e29 into main Jan 30, 2025
5 checks passed
@rowanseymour rowanseymour deleted the labels-fix branch January 30, 2025 01:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants