Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Renderer's Builder To A Member, Instantiated Once #2985

Open
alex-courtis opened this issue Nov 3, 2024 · 0 comments
Open

Move Renderer's Builder To A Member, Instantiated Once #2985

alex-courtis opened this issue Nov 3, 2024 · 0 comments
Labels
performance performance enhancement

Comments

@alex-courtis
Copy link
Member

Builder is currently constructed every renderer:draw() which is expensive.

Change it to a member of Renderer

It currently appears to retain state, which will need to be cleared.

Rename it to something more meaningful: LineRenderer, LineBuilder or fold it into Renderer
@alex-courtis alex-courtis added the performance performance enhancement label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance performance enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex-courtis