Error processing logic.

[whynowy]

		if retryError != nil {
			hs.logger.Errorf("HTTP Request failed. Error : %v", retryError)
			if hs.dropIfError {
				hs.logger.Warn("Dropping messages due to failure")
				return ok
                                 // -- Should it be appended to ok list instead of returning?
			}
			failed = failed.Append(sinksdk.ResponseFailure(datum.ID(), "failed to forward message"))
                         // -- This means the ID is added to "failed", as well as "ok" in the next next line.
		}
		ok = ok.Append(sinksdk.ResponseOK(datum.ID()))

numaflow-sinks/http-sink/main.go

Lines 95 to 103 in 1d49640

	if retryError != nil {
	hs.logger.Errorf("HTTP Request failed. Error : %v", retryError)
	if hs.dropIfError {
	hs.logger.Warn("Dropping messages due to failure")
	return ok
	}
	failed = failed.Append(sinksdk.ResponseFailure(datum.ID(), "failed to forward message"))
	}
	ok = ok.Append(sinksdk.ResponseOK(datum.ID()))