Skip to content
This repository has been archived by the owner on Oct 12, 2018. It is now read-only.

consistent alignment? #248

Open
ndushay opened this issue Aug 31, 2015 · 1 comment
Open

consistent alignment? #248

ndushay opened this issue Aug 31, 2015 · 1 comment

Comments

@ndushay
Copy link

ndushay commented Aug 31, 2015

I've been reading this code a fair bit lately, especially modules/module.MBIB-2-BIBFRAME-Shared.xqy, and I have been a bit frustrated by the seeming randomness of the indentation. For example, see
https://github.com/lcnetdev/marc2bibframe/blob/master/modules/module.MBIB-2-BIBFRAME-Shared.xqy#L427.

It would be fantastic if the files could be cleaned up to use consistent whitespace. I am willing to do this and submit a pull request, but since it will probably mess up a LOT of lines, I am disinclined to do so if folks working on the code are opposed.

If this is desired, let me know. It may also imply that further contributions by anyone should adhere to a specific whitespace practice. Typically, it is 2 spaces for an indent, and don't use tabs.

@ntra00
Copy link
Owner

ntra00 commented Sep 8, 2015

Development on this has been focussed on "get something working" and "change it to work this way", while we're in experimentation mode, to the detriment of readability and consistency, I"m sorry to say. We are going to have major changes to the vocabulary, so we will probably wait until after that for a major overhaul of the code.
That said, go ahead, if you have the time and would find it useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants