From ccad9f94d199d0fb75a3e554ef7c2361ddcc3183 Mon Sep 17 00:00:00 2001 From: iadgovuser58 <124906646+iadgovuser58@users.noreply.github.com> Date: Tue, 20 Aug 2024 14:06:43 -0400 Subject: [PATCH] removing default constructors due to checkstyles not liking it --- .../java/hirs/utils/tpm/eventlog/events/EvConstants.java | 6 +++--- .../tpm/eventlog/events/NvIndexDynamicEventLogData.java | 2 +- .../src/main/java/hirs/utils/tpm/eventlog/spdm/SpdmHa.java | 4 ---- .../java/hirs/utils/tpm/eventlog/uefi/UefiConstants.java | 6 +++--- 4 files changed, 7 insertions(+), 11 deletions(-) diff --git a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/EvConstants.java b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/EvConstants.java index f8fff263f..8f53f7cc3 100644 --- a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/EvConstants.java +++ b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/EvConstants.java @@ -1,13 +1,13 @@ package hirs.utils.tpm.eventlog.events; -import lombok.AccessLevel; -import lombok.NoArgsConstructor; +//import lombok.AccessLevel; +//import lombok.NoArgsConstructor; /** * Class for defining constants referenced in the PC Client * Platform Firmware Profile specification. */ -@NoArgsConstructor(access = AccessLevel.PRIVATE) +//@NoArgsConstructor(access = AccessLevel.PRIVATE) public final class EvConstants { /** diff --git a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/NvIndexDynamicEventLogData.java b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/NvIndexDynamicEventLogData.java index b4fa78e8b..f4318959e 100644 --- a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/NvIndexDynamicEventLogData.java +++ b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/events/NvIndexDynamicEventLogData.java @@ -34,7 +34,7 @@ public class NvIndexDynamicEventLogData { /** * Human-readable description of the data within this DEVICE_SECURITY_EVENT_DATA/..DATA2 event. */ - String nvIndexDynamicInfo = ""; + private String nvIndexDynamicInfo = ""; /** * NvIndexInstanceEventLogData constructor. diff --git a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/spdm/SpdmHa.java b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/spdm/SpdmHa.java index 63d3a7881..3ad7ce20d 100644 --- a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/spdm/SpdmHa.java +++ b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/spdm/SpdmHa.java @@ -1,13 +1,9 @@ package hirs.utils.tpm.eventlog.spdm; -import lombok.AccessLevel; -import lombok.NoArgsConstructor; - /** * Class for defining hash algorithms referenced in the DMTF SPDM specification. * SPDM 1.3.0, Table 21, MeasurementHashAlgo. */ -@NoArgsConstructor(access = AccessLevel.PRIVATE) public class SpdmHa { /** diff --git a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/uefi/UefiConstants.java b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/uefi/UefiConstants.java index d60bf67d1..8d54ba093 100644 --- a/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/uefi/UefiConstants.java +++ b/HIRS_Utils/src/main/java/hirs/utils/tpm/eventlog/uefi/UefiConstants.java @@ -1,14 +1,14 @@ package hirs.utils.tpm.eventlog.uefi; -import lombok.AccessLevel; -import lombok.NoArgsConstructor; +//import lombok.AccessLevel; +//import lombok.NoArgsConstructor; /** * This class contains the String constants that are referenced by UEFI. * It is expected that member properties of this class will expand as * more functionality is added. */ -@NoArgsConstructor(access = AccessLevel.PRIVATE) +//@NoArgsConstructor(access = AccessLevel.PRIVATE) public final class UefiConstants { /**