Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant lastStart in CountdownThreadHandler #16

Open
Rogavactive opened this issue Apr 17, 2020 · 0 comments
Open

Redundant lastStart in CountdownThreadHandler #16

Rogavactive opened this issue Apr 17, 2020 · 0 comments

Comments

@Rogavactive
Copy link
Contributor

Rogavactive commented Apr 17, 2020

lastStart is always less than current, it cannot be bigger than current time, that means remaining = (lastStart + duration) - current and if we reorder remaining = (lastStart - current) + duration - duration is always bigger than remaining and val countdownTime = max(remaining, duration) always will return duration in CountdownThreadHandler .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant