Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yuicompressor packages a modified rhino #78

Closed
bendlas opened this issue Jul 8, 2015 · 4 comments
Closed

yuicompressor packages a modified rhino #78

bendlas opened this issue Jul 8, 2015 · 4 comments
Assignees

Comments

@bendlas
Copy link

bendlas commented Jul 8, 2015

The yuicompressor dependency adds rhino classes to the classpath. There is an open PR for that, but the yuicompressor maintainers don't seem overly hesitant to fix it.

@priyatam priyatam self-assigned this Feb 2, 2016
@bendlas
Copy link
Author

bendlas commented Mar 23, 2016

@noprompt sorry, this fix doesn't work. yuicompressor repackages rhino. That means, that rhino classes are in the the yuicompressor .jar.

@noprompt
Copy link
Owner

I think this is a separate issue in that a solution to this problem, possibly the solution, would be to isolate the compression aspect of Garden in a separate library.

@priyatam
Copy link
Collaborator

I agree. We should remove all such dependencies and recommend postscss plugins. Garden can benefit in the long term when we avoid 3rd party deps.

@jeluard
Copy link
Collaborator

jeluard commented Mar 24, 2016

I agree too, I'd rather have garden focus on CSS generation.

Le jeu. 24 mars 2016 à 05:16, Priyatam Mudivarti [email protected]
a écrit :

I agree. We should remove all such dependencies and recommend postscss
http://postcss.org plugins. Garden can benefit in the long term when we
avoid 3rd party deps.


You are receiving this because you are subscribed to this thread.

Reply to this email directly or view it on GitHub
#78 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants