-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yuicompressor packages a modified rhino #78
Comments
@noprompt sorry, this fix doesn't work. yuicompressor repackages rhino. That means, that rhino classes are in the the yuicompressor |
I think this is a separate issue in that a solution to this problem, possibly the solution, would be to isolate the compression aspect of Garden in a separate library. |
I agree. We should remove all such dependencies and recommend postscss plugins. Garden can benefit in the long term when we avoid 3rd party deps. |
I agree too, I'd rather have garden focus on CSS generation. Le jeu. 24 mars 2016 à 05:16, Priyatam Mudivarti [email protected]
|
The yuicompressor dependency adds rhino classes to the classpath. There is an open PR for that, but the yuicompressor maintainers don't seem overly hesitant to fix it.
The text was updated successfully, but these errors were encountered: