Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @nodegui/nodegui phantom dependency #233

Open
matronator opened this issue Jul 25, 2021 · 0 comments
Open

Fix @nodegui/nodegui phantom dependency #233

matronator opened this issue Jul 25, 2021 · 0 comments

Comments

@matronator
Copy link

After starting webpack, it throws errors in several places, saying TS2307: Cannot find module '@nodegui/nodegui' or its corresponding type declarations. I noticed that @nodegui/nodegui is not declared anywhere in package.json despite being used in multiple places across the source code.

My guess is that you're relying on @nodegui/nodegui being included as a dependency from the @nodegui/react-nodegui package, making it a phantom dependency, which should be avoided. This isn't a problem when using regular npm and yarn, but it breaks (at least for me it did) when using pnpm.

Please consider adding @nodegui/nodegui as a dependency in this project or specify it as a peer dependency in the react-nodegui package to make it work effortlessly with pnpm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant